[fix][broker] Fix enableReplicatedSubscriptions #23781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixuan Liu <[email protected]>
|
/pulsarbot rerun-failure-checks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #23781 +/- ##
============================================
+ Coverage 73.57% 74.19% +0.61%
+ Complexity 32624 32141 -483
============================================
Files 1877 1853 -24
Lines 139502 143376 +3874
Branches 15299 16277 +978
============================================
+ Hits 102638 106373 +3735
+ Misses 28908 28629 -279
- Partials 7956 8374 +418
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
Dec 27, 2024
nodece
added a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 6e3eaf5)
nodece
added a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 6e3eaf5)
nodece
added a commit
that referenced
this pull request
Dec 30, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 6e3eaf5)
nikhil-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 31, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 6e3eaf5) (cherry picked from commit 222d41c)
srinath-ctds
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 31, 2024
Signed-off-by: Zixuan Liu <[email protected]> (cherry picked from commit 6e3eaf5) (cherry picked from commit 222d41c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#23757 breaks
enableReplicatedSubscriptionsconfig.Modifications
When
enableReplicatedSubscriptions=false, disable the subscription replication.Documentation
docdoc-requireddoc-not-neededdoc-complete